[Webkit-unassigned] [Bug 37514] [CSS3 Backgrounds and Borders] Implement CSS3 background-position offsets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37514


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79942|commit-queue?               |
               Flag|                            |




--- Comment #5 from Eric Seidel <eric at webkit.org>  2011-04-06 10:20:42 PST ---
(From update of attachment 79942)
View in context: https://bugs.webkit.org/attachment.cgi?id=79942&action=review

WE need to find ways to share more code here.  You have so many copy/paste code paths.

> Source/WebCore/css/CSSParser.cpp:2601
> +    } else {
> +        valueX = CSSPrimitiveValue::create(Pair::create(CSSPrimitiveValue::createIdentifier(CSSValueLeft), value));
> +    }

No {} on one line clauses.  Seems we might want to wrap this in a helper method, since you seem to do the same thing in all 3 of these cases, and at least the CSSPrimativeValue::create call could be shared.

> Source/WebCore/css/CSSParser.cpp:2605
> +static PassRefPtr<CSSPrimitiveValue> createBackgroundPositionY(PassRefPtr<CSSPrimitiveValue> pValue, bool usePair = true)

Soooo much duplicated code :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.