[Webkit-unassigned] [Bug 54969] [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput implementation

Wed Apr 6 09:43:46 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=54969

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88434|review?                     |review+
               Flag|                            |

--- Comment #32 from Alexey Proskuryakov <ap at webkit.org>  2011-04-06 09:43:46 PST ---
(From update of attachment 88434)
View in context: https://bugs.webkit.org/attachment.cgi?id=88434&action=review

Great!

> Source/WebKit/mac/WebView/WebFrame.mm:676
> +    size_t location, length;

I don't know why I didn't mention that before, but we don't declare two variables on one line.

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:281
> +    size_t locationSize, lengthSize;

Ditto.

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:296
> +    size_t locationSize, lengthSize;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.