[Webkit-unassigned] [Bug 57955] [GTK] Do not reference AccessibilityRenderObject from platform dependent code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57955





--- Comment #3 from Mario Sanchez Prada <msanchez at igalia.com>  2011-04-06 09:36:47 PST ---
(In reply to comment #2)
> (From update of attachment 88443 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88443&action=review
> 
> looks good modulus changes
> 
> > Source/WebCore/accessibility/AccessibilityObject.h:359
> > +
> 
> I would put this directly below node(), with no extra line between them,
> because they are related

Ok, I'll change that before committing.

> > Source/WebCore/accessibility/AccessibilityObject.h:410
> >      virtual AccessibilityObject* correspondingControlForLabelElement() const { return 0; }
> 
> does correspondingLabelForControlElement need to be made virtual in
> AXRenderObject.h?

Nope, as it is already virtual in there :-)

Thanks for the review. Committing...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.