[Webkit-unassigned] [Bug 40254] [Qt] FrameLoaderClientQt.cpp has coding-style errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40254





--- Comment #5 from Alexis Menard <alexis.menard at openbossa.org>  2011-04-06 09:34:13 PST ---
(From update of attachment 88445)
View in context: https://bugs.webkit.org/attachment.cgi?id=88445&action=review

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:47
> +#include "HistoryItem.h"

I'm not sure but this should go before HTMLAppletElement.h

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:91
> +#include <qfileinfo.h>

can you use <QFileInfo> instead and mix it with the other Qt includes?

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1053
> +    // qDebug() << "FrameLoaderClientQt::dispatchWillSendRequest" << request.isNull() << request.url().string`();

What is this `?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.