[Webkit-unassigned] [Bug 57948] JSC bindings generator: support non-object numbers as callback arguments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 09:31:15 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57948


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88424|review?                     |review-
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2011-04-06 09:31:16 PST ---
(From update of attachment 88424)
View in context: https://bugs.webkit.org/attachment.cgi?id=88424&action=review

> Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp:141
> +bool JSTestCallback::callbackWithInteger(int* intParam)
> +{
> +    if (!canInvokeCallback())
> +        return true;
> +
> +    RefPtr<JSTestCallback> protect(this);
> +
> +    JSLock lock(SilenceAssertionsOnly);
> +
> +    MarkedArgumentBuffer args;
> +    args.append(jsNumber(static_cast<int>(intParam)));

This is definitely wrong and won’t even compile. You can’t just cast an int* to an int.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list