[Webkit-unassigned] [Bug 57770] Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57770


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88436|review-                     |review+
               Flag|                            |




--- Comment #26 from Darin Adler <darin at apple.com>  2011-04-06 09:29:36 PST ---
(From update of attachment 88436)
View in context: https://bugs.webkit.org/attachment.cgi?id=88436&action=review

>> Source/WebCore/bindings/js/CallbackFunction.h:52
>> +        return JSCallbackType::create(asObject(value), globalObject);
> 
> Sorry, the refactoring I asked you for broke the function. This line will assert or crash when asObject is called on a null or undefined value.

No, my mistake.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.