[Webkit-unassigned] [Bug 57955] [GTK] Do not reference AccessibilityRenderObject from platform dependent code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 09:16:58 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57955


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88443|review?                     |review+
               Flag|                            |




--- Comment #2 from chris fleizach <cfleizach at apple.com>  2011-04-06 09:16:58 PST ---
(From update of attachment 88443)
View in context: https://bugs.webkit.org/attachment.cgi?id=88443&action=review

looks good modulus changes

> Source/WebCore/accessibility/AccessibilityObject.h:359
> +

I would put this directly below node(), with no extra line between them, because they are related

> Source/WebCore/accessibility/AccessibilityObject.h:410
>      virtual AccessibilityObject* correspondingControlForLabelElement() const { return 0; }

does correspondingLabelForControlElement need to be made virtual in AXRenderObject.h?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list