[Webkit-unassigned] [Bug 57530] [Qt] GraphicsContext3D internal buffers are not freed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57530


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88264|review?                     |review-
               Flag|                            |




--- Comment #4 from Benjamin Poulain <benjamin at webkit.org>  2011-04-06 09:06:45 PST ---
(From update of attachment 88264)
View in context: https://bugs.webkit.org/attachment.cgi?id=88264&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:455
> +    m_glWidget->makeCurrent();
> +    if (m_glWidget->isValid()) {
> +        ::glDeleteTextures(1, &m_texture);
> +        deleteRenderbuffers(1, &m_depthBuffer);
> +        deleteFramebuffers(1, &m_canvasFbo);
> +    }

Please resubmit the patch with just this.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:597
> +        void* addr = m_glWidget->context()->getProcAddress(QString::fromUtf8(nameWithExt.utf8().data()));

Actually, looking at it, shouldn't it be QString(nameWithExt)?
I don't see why we should pass by UTF-8 to convert for WTF::String to QString.

You should commit this separately. It seems unrelated with the resource cleaning.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:665
> +    if ((width == m_currentWidth && height == m_currentHeight) || (!m_internal))

No problem with that but you can commit that separately, with the above change, in a code cleaning patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.