[Webkit-unassigned] [Bug 56752] [Qt] The minimum size of the select menu list is incorrect for qtwebkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56752


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87900|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #17 from Benjamin Poulain <benjamin at webkit.org>  2011-04-06 05:52:26 PST ---
(From update of attachment 87900)
View in context: https://bugs.webkit.org/attachment.cgi?id=87900&action=review

r- because of the test being Qt specific without justification for that.
If a layout issue is not covered by existing test, you should improve the tests for everyone, not just for Qt.

> Source/WebCore/ChangeLog:5
> +        [QT]The minimum size of the select menu list is incorrect for qtwebkit 

Qt, not QT.

> LayoutTests/ChangeLog:5
> +        [QT]The minimum size of the select menu list is incorrect for qtwebkit 

Qt

> LayoutTests/platform/qt/fast/forms/selectlist-minsize.html:5
> +            [QT]The minimum size of the select menu list is incorrect for qtwebkit <br>

Qt

> LayoutTests/platform/qt/fast/forms/selectlist-minsize.html:9
> +        <select id="list3">

Why is there an id?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.