[Webkit-unassigned] [Bug 49791] [GTK] Implement SharedMemory for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49791





--- Comment #43 from Balazs Kelemen <kbalazs at webkit.org>  2011-04-06 05:43:36 PST ---
(From update of attachment 87745)
View in context: https://bugs.webkit.org/attachment.cgi?id=87745&action=review

> Source/WebKit2/ChangeLog:20
> +        * Platform/CoreIPC/unix/AttachmentUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/AttachmentQt.cpp.

The Changelog is out of date. The file you add is AttachmentPOSIX.cpp.
Please fix this before landing.

> Source/WebKit2/GNUmakefile.am:100
> +	Source/WebKit2/Platform/CoreIPC/posix/AttachmentPOSIX.cpp \

I'm not a fan of adding two new terminology with new dirs and file name patterns. (Just my personal opinion, should not block the patch).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.