[Webkit-unassigned] [Bug 57918] Add QUOTA build flag for unified quota API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57918





--- Comment #2 from Kinuko Yasuda <kinuko at chromium.org>  2011-04-05 23:41:23 PST ---
(From update of attachment 88369)
Thanks for working on this!

View in context: https://bugs.webkit.org/attachment.cgi?id=88369&action=review

Have you forgotten to add the similar change in configure.ac (and top level ChangeLog)?

> Source/WebCore/ChangeLog:1
> +2011-04-05  Dai Mikurube  <dmikurube at google.com>

Different address from the one in others (chromium.org vs google.com).

> Source/WebCore/WebCore.pri:169
> +!contains(DEFINES, ENABLE_QUOTA=.): DEFINES += ENABLE_QUOTA=0 

Seems like we should put this in Source/WebCore/features.pri instead?

> Source/WebKit/chromium/ChangeLog:1
> +2011-04-05  Dai Mikurube  <dmikurube at google.com>

ditto.

> Source/WebKit/chromium/features.gypi:78
> +        'ENABLE_QUOTA=1',

Please do not enable this yet.  (You can just remove this line for now)

> Source/WebKit/mac/ChangeLog:1
> +2011-04-05  Dai Mikurube  <dmikurube at google.com>

ditto.

> WebKitLibraries/ChangeLog:1
> +2011-04-05  Dai Mikurube  <dmikurube at google.com>

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.