[Webkit-unassigned] [Bug 57755] REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element

Tue Apr 5 23:22:20 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=57755

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88353|review?                     |review-
               Flag|                            |

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2011-04-05 23:22:21 PST ---
(From update of attachment 88353)
View in context: https://bugs.webkit.org/attachment.cgi?id=88353&action=review

> LayoutTests/editing/execCommand/insert-line-break-onload.html:1
> +<body onload="go()">

Missing DOCTYPE.

> LayoutTests/editing/execCommand/insert-line-break-onload.html:2
> +Test InsertLineBreak is called correctly without any exception.

Mn... I'd expect that adding this line would stop reproducing the crash.  Did you make sure this test case cause a crash?

> LayoutTests/editing/execCommand/insert-line-break-onload.html:10
> +    var result = "Calling InsertLineBreak succeeded without any exception.";

I'd just print 'PASS' with the test description because that's what other tests do.

> LayoutTests/editing/execCommand/insert-line-break-onload.html:15
> +    } else
> +        alert(result);

Why do you need an alert here?  I'd expect for document.write to work here as well.

> Source/WebCore/editing/TypingCommand.cpp:52
> +    if (Node* node = selection.rootEditableElement()) {

We normally do an early exit in these cases.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.