[Webkit-unassigned] [Bug 57888] Need to extend WebKit chromium API to access text selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57888





--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-04-05 21:55:26 PST ---
(From update of attachment 88314)
View in context: https://bugs.webkit.org/attachment.cgi?id=88314&action=review

> Source/WebKit/chromium/public/WebFrame.h:412
> +    virtual void selectBetweenWindowPoints(const WebPoint& startPoint,

would it make sense to call this "selectRange"?

also, in WebWidget.h, you just refer to these parameters using the names
"start" and "end".  maybe you should use the same names here as you do there
for consistency?

> Source/WebKit/chromium/public/WebWidget.h:130
> +    // Returns the start and point for the current selection, aligned to the

"start and [end] point" ??

> Source/WebKit/chromium/public/WebWidget.h:132
> +    virtual bool selectionStartAndEndPoints(WebPoint& start,

would it make sense to call this selectionRange?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.