[Webkit-unassigned] [Bug 56602] [Chromium] Inspector does not always shows transferred size correctly (e.g. gzipped/chunked content)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 5 11:48:01 PDT 2011


--- Comment #16 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-04-05 11:48:01 PST ---
(From update of attachment 87333)
View in context: https://bugs.webkit.org/attachment.cgi?id=87333&action=review

> Source/WebKit/chromium/public/WebURLLoaderClient.h:61
> +    // FIXME(vsevik): rename once original didReceiveData() is removed.

nit: webkit style is to not put names next to FIXME.

nit: you should document lengthReceived.  it is not obvious how dataLength and lengthReceived differ.
if you read the comment "Called when a chunk of response data is received", then you might think that
lengthReceived indicates the amount received this time, but actually that is dataLength.  also, there
is no indication that lengthReceived somehow relates to the length before the data was decompressed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list