[Webkit-unassigned] [Bug 57859] Add implementations of JavaInstance, JavaClass, JavaField and JavaMethod that simply proxy calls to a listener.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 5 11:12:02 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=57859
--- Comment #2 from Dimitri Glazkov (Google) <dglazkov at chromium.org> 2011-04-05 11:12:02 PST ---
(From update of attachment 88281)
View in context: https://bugs.webkit.org/attachment.cgi?id=88281&action=review
> Source/WebCore/bridge/jni/v8/JavaFieldProxyV8.h:51
> + static PassRefPtr<JavaFieldProxy> create(int id, String name, String typeClassName) { return adoptRef(new JavaFieldProxy(id, name, typeClassName)); }
> +
> + // JavaField implementation
> + virtual String name() const { return m_name; }
> + virtual const char* typeClassName() const { return m_typeClassName.utf8().data(); }
> + virtual JavaType type() const { return javaTypeFromClassName(m_typeClassName.utf8().data()); }
> +
> + int id() const { return m_id; }
Can you move these out of a decl? You can place them in the header below the class if you want to inline them.
> Source/WebCore/bridge/jni/v8/JavaInstanceProxyV8.h:50
> + virtual JavaClass* getClass() const { return &m_class; }
> + virtual JavaValue invokeMethod(const JavaMethod* method, JavaValue* args) { return invokeMethod(static_cast<const JavaMethodProxy*>(method), args); }
> + virtual JavaValue getField(const JavaField* field) { return getField(static_cast<const JavaFieldProxy*>(field)); }
> + virtual void begin() {}
> + virtual void end() {}
> +
> + void addMethod(int id, bool isStatic, String name, String returnTypeClassName, const Vector<String> ¶meters) { return m_class.addMethod(id, isStatic, name, returnTypeClassName, parameters); }
> + void addField(int id, String name, String typeClassName) { m_class.addField(id, name, typeClassName); }
Ditto.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list