[Webkit-unassigned] [Bug 57770] Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57770





--- Comment #12 from Leandro Graciá Gil <leandrogracia at chromium.org>  2011-04-05 10:30:12 PST ---
(From update of attachment 88260)
View in context: https://bugs.webkit.org/attachment.cgi?id=88260&action=review

>> Source/WebCore/bindings/js/CallbackFunction.h:42
>> +// 'FunctionOnly' is assumed for the created callback.
> 
> Let's make this explicit - 'Creates callback objects for callbacks marked as FunctionOnly in WebIDL'.

Fixed.

>> Source/WebCore/bindings/js/CallbackFunction.h:52
>> +    if (!value.getCallData() != CallTypeNone) {
> 
> I think it best to keep the bug fix in a separate patch from this refactoring. You can do the fix in Bug 40012 and do so for V8 and JSC together. In any case, you have an extra '!' here.

Done. Restored original contents to separate the refactoring from fixing the problem. This latter task is left to bug 40012.

>> Source/WebCore/bindings/js/JSGeolocationCustom.cpp:117
>> +        static_cast<JSDOMGlobalObject*>(exec->lexicalGlobalObject()), exec->argument(0), CallbackAllowFunction);
> 
> No need for these line breaks.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.