[Webkit-unassigned] [Bug 53066] Web Inspector: fix data url's status and timing the network panel.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 5 10:15:05 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=53066


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88246|review?                     |review-
               Flag|                            |




--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2011-04-05 10:15:05 PST ---
(From update of attachment 88246)
View in context: https://bugs.webkit.org/attachment.cgi?id=88246&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1524
> +                this._statusCell.textContent = WebInspector.UIString("(data url)");

You need to update English.lproj/localizedStrings.js with new string.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1525
> +                this._statusCell.addStyleClass("network-dim-cell");

Seems like this line is common.

> Source/WebCore/inspector/front-end/Resource.js:716
> +    isFromDataURL: function()

nit: isDataURL

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list