[Webkit-unassigned] [Bug 57770] Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 5 09:59:38 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=57770
Steve Block <steveblock at google.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88260| |commit-queue-
Flag| |
--- Comment #10 from Steve Block <steveblock at google.com> 2011-04-05 09:59:37 PST ---
(From update of attachment 88260)
View in context: https://bugs.webkit.org/attachment.cgi?id=88260&action=review
> Source/WebCore/bindings/js/CallbackFunction.h:42
> +// 'FunctionOnly' is assumed for the created callback.
Let's make this explicit - 'Creates callback objects for callbacks marked as FunctionOnly in WebIDL'.
> Source/WebCore/bindings/js/CallbackFunction.h:52
> + if (!value.getCallData() != CallTypeNone) {
I think it best to keep the bug fix in a separate patch from this refactoring. You can do the fix in Bug 40012 and do so for V8 and JSC together. In any case, you have an extra '!' here.
> Source/WebCore/bindings/js/JSGeolocationCustom.cpp:117
> + static_cast<JSDOMGlobalObject*>(exec->lexicalGlobalObject()), exec->argument(0), CallbackAllowFunction);
No need for these line breaks.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list