[Webkit-unassigned] [Bug 57854] [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57854





--- Comment #3 from Xan Lopez <xan.lopez at gmail.com>  2011-04-05 09:32:32 PST ---
(From update of attachment 88250)
View in context: https://bugs.webkit.org/attachment.cgi?id=88250&action=review

> Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:510
> +    GOwnPtr<gchar> rangeString(g_strdup_printf("{0, 0}"));

This can just be g_strdup.

> Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:551
> +    return JSStringCreateWithUTF8CString(rangeString.get());

These two methods are almost exactly identical (only difference seems to be to use column or row in the printf). I think you can refactor it to make both call a common method that does either one depending on a parameter, for instance?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.