[Webkit-unassigned] [Bug 57530] [Qt] GraphicsContext3D internal buffers are not freed

Tue Apr 5 06:02:36 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=57530

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87685|review?                     |review-
               Flag|                            |

--- Comment #2 from Benjamin Poulain <benjamin at webkit.org>  2011-04-05 06:02:36 PST ---
(From update of attachment 87685)
View in context: https://bugs.webkit.org/attachment.cgi?id=87685&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:597
> +        void* addr = m_glWidget->context()->getProcAddress(QString::fromAscii(nameWithExt.utf8().data()));

QString::fromAscii() is almost never valid inside a library. It does not actually convert from Ascii, but from the default codec, which can be set to anything by the user code.
You should use QString::fromLatin1() or QLatin1String() or in thisn case: QString::fromUtf8().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.