[Webkit-unassigned] [Bug 45889] Style visibility: hidden on <br/> tags causes input fields to lose focus after deleting all content

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45889





--- Comment #37 from Ryosuke Niwa <rniwa at webkit.org>  2011-04-05 05:38:44 PST ---
I tested your patch and I'm getting a crash on editing/execCommand/indent-node-to-split-to-crash.html with the following stack trace.

SHOULD NEVER BE REACHED
/Volumes/Data/webkit2/Source/WebCore/editing/ApplyBlockElementCommand.cpp(142) : virtual void WebCore::ApplyBlockElementCommand::formatSelection(const WebCore::VisiblePosition&, const WebCore::VisiblePosition&)
1   WebCore::ApplyBlockElementCommand::formatSelection(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&)
2   WebCore::IndentOutdentCommand::formatSelection(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&)
3   WebCore::ApplyBlockElementCommand::doApply()
4   WebCore::EditCommand::apply()
5   WebCore::applyCommand(WTF::PassRefPtr<WebCore::EditCommand>)
6   WebCore::executeIndent(WebCore::Frame*, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&)
7   WebCore::Editor::Command::execute(WTF::String const&, WebCore::Event*) const
8   WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&)

The other test failure was due to
LayoutTests/platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt.  You should just remove that file and rebaseline LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt since they're identical.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.