[Webkit-unassigned] [Bug 57822] Build fix for YarrParser.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57822





--- Comment #6 from Balazs Kelemen <kbalazs at webkit.org>  2011-04-05 04:28:53 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > The other bug has not patch and I won't re-upload mine.
> Nobody asked you to upload your patch again ...
> 
> > 0 is seems like a natural value for UChar. Here is some grep output:
> > Source/JavaScriptCore/runtime/StringPrototype.cpp:865:    UChar ored = 0;
> > Source/JavaScriptCore/runtime/StringPrototype.cpp:905:    UChar ored = 0;
> > Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:81:    UChar u = 0;
> 
> It is absolutely useless information. We can't fix the bug without understanding the Yarr parser. I don't know if m_character is used
> somewhere before initializing.

Don't you think that 0 is better than memory garbage? What else can be the initialization value for an integral type? I don't understand your concerns.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.