[Webkit-unassigned] [Bug 57822] Build fix for YarrParser.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 5 03:12:06 PDT 2011


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
             Status|REOPENED                    |NEW

--- Comment #4 from Csaba Osztrogonac <ossy at webkit.org>  2011-04-05 03:12:06 PST ---
(In reply to comment #3)
> The other bug has not patch and I won't re-upload mine.
Nobody asked you to upload your patch again ...

> 0 is seems like a natural value for UChar. Here is some grep output:
> Source/JavaScriptCore/runtime/StringPrototype.cpp:865:    UChar ored = 0;
> Source/JavaScriptCore/runtime/StringPrototype.cpp:905:    UChar ored = 0;
> Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:81:    UChar u = 0;

It is absolutely useless information. We can't fix the bug without understanding the Yarr parser. I don't know if m_character is used
somewhere before initializing. But using a possibly wrong init value
is so wrong as using an uninitialized value.

Gavin, could you check if this initialization is correct or not?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list