[Webkit-unassigned] [Bug 57760] Factoring the creation of 'FunctionOnly' callbacks in V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57760


Steve Block <steveblock at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88086|review?                     |review+
               Flag|                            |




--- Comment #6 from Steve Block <steveblock at google.com>  2011-04-05 02:57:53 PST ---
(From update of attachment 88086)
View in context: https://bugs.webkit.org/attachment.cgi?id=88086&action=review

> Source/WebCore/bindings/v8/V8Utilities.h:61
> +        CallbackRequireFunction = 1,

Would 'CallbackAllowFunction' be a better name, to keep all three consistent, and to make clear what 'CallbackRequireFunction | CallbackAllowUndefined' means?

> Source/WebCore/bindings/v8/V8Utilities.h:77
> +        // 'FunctionOnly' is assumed for the created callback.

This comment seems a little odd. Maybe move it to above the method - 'Creates a callback of the templated type from a V8 Value which represents a function object. Values of null and undefined may be allowed, in which case the method succeeds but the callback is null.'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.