[Webkit-unassigned] [Bug 56904] [EFL] Update signals description

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 4 23:52:33 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56904





--- Comment #17 from Grzegorz <g.czajkowski at samsung.com>  2011-04-04 23:52:33 PST ---
(In reply to comment #16)
> (From update of attachment 88036 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88036&action=review
> 
> > Source/WebKit/efl/ewk/ewk_frame.h:51
> > - *  - "title,changed", const char*: title of the main frame changed.
> > - *  - "uri,changed", const char*: uri of the main frame changed.
> > - *  - "load,document,finished", void: loading of a document has
> > - *    finished on this frame.
> > + *  - "title,changed", const char*: title of the main frame was changed.
> > + *  - "uri,changed", const char*: uri of the main frame was changed.
> > + *  - "load,document,finished", void: frame finished loading the document.
> 
> Why are you changing these sentences to use past continuous instead of past? While I'm not really against, I don't see a reason to do so.

I tried to use a passive voice instead of past for example, in first case we can write:
a) main frame changed the title
or
b) title of the main frame was changed
but 
c) title of the main frame changed - doesn't sound well in my opinion
I would like to encourage you to use a) or b)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list