[Webkit-unassigned] [Bug 57644] [GTK] Flash in divs with overflow: auto is not positioned and clipped properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57644





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-04-04 23:41:50 PST ---
(From update of attachment 88121)
View in context: https://bugs.webkit.org/attachment.cgi?id=88121&action=review

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:497
> +    if (!m_clipRect.width() || !m_clipRect.height()) {

maybe if (m_clipRect.isEmpty()) is more clear here.

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:556
> +        cairo_rectangle_int_t clipRect = m_clipRect;

GdkRectangle is cairo_rectangle_int_t, so you can move GdkRectangle clipRect = m_clipRect; out of the #ifdef block and use it for both gtk2 and gtk3

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.