[Webkit-unassigned] [Bug 50952] Inputs of type "text" and "search" should support interoperable "set direction" functionality

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50952


Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88186|                            |review?
               Flag|                            |




--- Comment #26 from Hironori Bono <hbono at chromium.org>  2011-04-04 23:33:10 PST ---
Created an attachment (id=88186)
 --> (https://bugs.webkit.org/attachment.cgi?id=88186&action=review)
A quick fix v5

Greetings Alexey and Eric,

Thank you for your reviews and sorry for my slow response. I have updated my layout test to apply the comment from Alexey. It would be definitely helpful to give me your feedback.

(In reply to comment #24)
> There is no need to force gc with your own code - js-test-pre.js provides a nice gc() function.

Thank you for noticing it. It is really nice and I would love to use this function.

(In reply to comment #25)
> Still LGTM.

Thank you again for your positive review. Even though the updated one is almost as same as the previous one, would it be possible to review the updated one?

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.