[Webkit-unassigned] [Bug 31517] [GTK] WebGL support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31517





--- Comment #19 from Martin Robinson <mrobinson at webkit.org>  2011-04-04 14:38:16 PST ---
(In reply to comment #18)

Thank you very kindly for the review.

> > Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp:60
> > +        addedAtExitHandler = false;
> 
> Looks like you want true here? I guess this raises the pressure on us to find a cross-platform way of cleaning up on exit heh. Didn't we have something added for the icon database at some point?

You're right! I will fix this before landing.
> 
> > Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp:102
> > +    static bool initialized = false;
> > +    static bool success = true;
> > +    if (!initialized) {
> > +        success = initializeOpenGLShims();
> > +        initialized = true;
> > +    }
> > +    if (!success)
> > +        return 0;
> 
> Just to make sure I understand this - if we fail to initialize the shims we're essentially out of luck and won't be able to support webgl, and there's no point in trying to initialize them again, so we cache the failure, that sounds good yeah.

Exactly right.

> > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:924
> > +    * Since: 1.3.7
> 
> Needs to be 1.3.14, or would it be 1.3.15? =)

Will fix this!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.