[Webkit-unassigned] [Bug 50661] Convert <meter> shadow DOM to a DOM-based shadow.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50661





--- Comment #14 from MORITA Hajime <morrita at google.com>  2011-04-04 14:37:26 PST ---
Dimitri, thank you for another turn!

(In reply to comment #11)
> 
> > LayoutTests/ChangeLog:10
> > +        as normal flexboxes and its layout result is actually different,
> 
> This probably needs an update.
Updated the ChangeLog description.

> 
> > Source/WebCore/html/HTMLMeterElement.cpp:52
> > +    RefPtr<HTMLMeterElement> creating = adoptRef(new HTMLMeterElement(tagName, document, form));
> 
> creating -> meter
renamed.

> 
> > Source/WebCore/html/HTMLMeterElement.h:61
> > +    bool shouldShadowHaveRenderer() const;
> 
> You can now use rendererIsNeeded here.
Good point. I moved this and related code to MeterShadowElement.

> 
> > Source/WebCore/html/HTMLMeterElement.h:74
> > +    void setupShadow();
> 
> Can we call it createShadowSubtree, for consistency? That's what I called it in InputType.
> 
Sure.

> > Source/WebCore/html/shadow/MeterShadowElement.h:62
> > +    static PassRefPtr<MeterBarElement> create(Document* document) { return adoptRef(new MeterBarElement(document)); }
> 
> Move to an inline definition right after the class decl. See http://google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/html/shadow/SliderThumbElement.h&l=76
> 
> > Source/WebCore/html/shadow/MeterShadowElement.h:73
> > +    static PassRefPtr<MeterValueElement> create(Document* document) { return adoptRef(new MeterValueElement(document)); }
> 
> Ditto.
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.