[Webkit-unassigned] [Bug 57400] Fullscreen code assumes all layers use GPU compositing when USE(ACCELERATED_COMPOSITING)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57400


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87432|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from David Levin <levin at chromium.org>  2011-04-04 14:20:09 PST ---
(From update of attachment 87432)
View in context: https://bugs.webkit.org/attachment.cgi?id=87432&action=review

> Source/WebCore/ChangeLog:9
> +        Accelerated compositing may be compiled in but disabled at runtime or for so

This sentence looks incomplete.

> Source/WebCore/dom/Document.cpp:4924
> +          page()->chrome()->client()->setRootFullScreenLayer(m_fullScreenRenderer->layer()->backing()->graphicsLayer());

Your indent is incorrect. (4 space indent in WK unlike chromium with a 2 space indent).

> Source/WebCore/dom/Document.cpp:4949
> +          page()->chrome()->client()->setRootFullScreenLayer(m_fullScreenRenderer->layer()->backing()->graphicsLayer());

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.