[Webkit-unassigned] [Bug 50661] Convert <meter> shadow DOM to a DOM-based shadow.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 4 14:07:31 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=50661
Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88117|review? |review-
Flag| |
--- Comment #11 from Dimitri Glazkov (Google) <dglazkov at chromium.org> 2011-04-04 14:07:31 PST ---
(From update of attachment 88117)
View in context: https://bugs.webkit.org/attachment.cgi?id=88117&action=review
This is super-close! Thanks for working on this.
> LayoutTests/ChangeLog:10
> + as normal flexboxes and its layout result is actually different,
This probably needs an update.
> Source/WebCore/html/HTMLMeterElement.cpp:52
> + RefPtr<HTMLMeterElement> creating = adoptRef(new HTMLMeterElement(tagName, document, form));
creating -> meter
> Source/WebCore/html/HTMLMeterElement.h:61
> + bool shouldShadowHaveRenderer() const;
You can now use rendererIsNeeded here.
> Source/WebCore/html/HTMLMeterElement.h:74
> + void setupShadow();
Can we call it createShadowSubtree, for consistency? That's what I called it in InputType.
> Source/WebCore/html/shadow/MeterShadowElement.h:62
> + static PassRefPtr<MeterBarElement> create(Document* document) { return adoptRef(new MeterBarElement(document)); }
Move to an inline definition right after the class decl. See http://google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/html/shadow/SliderThumbElement.h&l=76
> Source/WebCore/html/shadow/MeterShadowElement.h:73
> + static PassRefPtr<MeterValueElement> create(Document* document) { return adoptRef(new MeterValueElement(document)); }
Ditto.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list