[Webkit-unassigned] [Bug 50661] Convert <meter> shadow DOM to a DOM-based shadow.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50661





--- Comment #10 from MORITA Hajime <morrita at google.com>  2011-04-04 14:01:09 PST ---
Hi Dimitri, thank you for lightning feedback!
I updated patch for address yours.


> 1) Do we really need filling element? Can't the meter itself act as the filling?
As you mentioned on the demo, I removed filling and use box-sizing and relative size specification
instead.

> 2) creating subtree on attach seems wrong. We'll be adding DOM elements at the time when we're supposed to be populating the render tree.
Sure. I moved shadow creation timing into HTMLMeterElement::create().

> 
> > LayoutTests/ChangeLog:9
> > +        Also updated meter-styles.html pixel result because the render tree is now layouted
> 
> layouted -> laid out
Fixed.

> 
> > Source/WebCore/ChangeLog:15
> > +          -webkit-appeearance is "none" and the platform supports <meter>.
> 
> -webkit-appearance
Fixed.

> 
> > Source/WebCore/ChangeLog:18
> > +          indicators are painted using the platform theme engine as same
> > +          old.
> 
> as before.
Fixed.

> 
> > Source/WebCore/css/CSSMutableStyleDeclaration.cpp:615
> > +bool CSSMutableStyleDeclaration::setProperty(int propertyID, double value, CSSPrimitiveValue::UnitTypes unit, bool important, bool notifyChanged)
> > +{
> > +    CSSProperty property(propertyID, CSSPrimitiveValue::create(value, unit), important);
> > +    setPropertyInternal(property);
> > +    if (notifyChanged)
> > +        setNeedsStyleRecalc();
> > +    return true;
> > +}
> 
> Do you need this change? Can you not just use
> 
> > Source/WebCore/html/shadow/MeterShadowElement.cpp:52
> > +    getInlineStyleDecl()->setProperty(CSSPropertyWebkitBoxFlex, flex, CSSPrimitiveValue::CSS_NUMBER);
> 
> can be just style()->
Non-mutable CSSStyleDeclaration doesn't have typed property access. It has only string-based API.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.