[Webkit-unassigned] [Bug 57768] Accelerated Canvas2D path failing when constructing large canvases.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57768





--- Comment #6 from Jeff Timanus <twiz at chromium.org>  2011-04-04 13:55:58 PST ---
(From update of attachment 88115)
View in context: https://bugs.webkit.org/attachment.cgi?id=88115&action=review

>> Source/WebCore/platform/graphics/gpu/DrawingBuffer.h:69
>> +
> 
> IMO instead of having an isValid() DrawingBuffer::create() should return NULL if the drawing buffer couldn't be constructed, and reset() should return false if it can't resize to the new bounds.

Will upload a new patch with your suggested changes.

>> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:621
>> +    }
> 
> It seems weird to short-circuit the normal error handling, but only for this function and only for chromium.  What do you think, Ken?
> 
> This check is wrong if level != 0, I believe.

You're right that it's a little different to add the error handling here.  I wanted the routine to respect the comments in GraphicsContext3DInternal.h   (http://www.google.com/codesearch/p?vert=chromium#OAMlx_jo-ck/src/third_party/WebKit/Source/WebKit/chromium/src/GraphicsContext3DInternal.h&l=190)

I believe it should work for levels other than 0.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.