[Webkit-unassigned] [Bug 56904] [EFL] Update signals description

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 4 13:54:12 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56904





--- Comment #16 from Lucas De Marchi <demarchi at webkit.org>  2011-04-04 13:54:11 PST ---
(From update of attachment 88036)
View in context: https://bugs.webkit.org/attachment.cgi?id=88036&action=review

> Source/WebKit/efl/ewk/ewk_frame.h:51
> - *  - "title,changed", const char*: title of the main frame changed.
> - *  - "uri,changed", const char*: uri of the main frame changed.
> - *  - "load,document,finished", void: loading of a document has
> - *    finished on this frame.
> + *  - "title,changed", const char*: title of the main frame was changed.
> + *  - "uri,changed", const char*: uri of the main frame was changed.
> + *  - "load,document,finished", void: frame finished loading the document.

Why are you changing these sentences to use past continuous instead of past? While I'm not really against, I don't see a reason to do so.

> Source/WebKit/efl/ewk/ewk_frame.h:66
> - *    changed due new layout, script actions or any other events.
> - *  - "navigation,first", void: first navigation occurred.
> + *     were changed due new layout, script actions or any other events.
> + *  - "navigation,first", void: first navigation was occurred.

And I think here it's weird to use "was occurred".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list