[Webkit-unassigned] [Bug 57768] Accelerated Canvas2D path failing when constructing large canvases.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57768





--- Comment #4 from James Robinson <jamesr at chromium.org>  2011-04-04 13:44:54 PST ---
(From update of attachment 88115)
View in context: https://bugs.webkit.org/attachment.cgi?id=88115&action=review

> Source/WebCore/platform/graphics/gpu/DrawingBuffer.h:69
> +    bool isValid() const { return m_context; }
> +

IMO instead of having an isValid() DrawingBuffer::create() should return NULL if the drawing buffer couldn't be constructed, and reset() should return false if it can't resize to the new bounds.

> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:621
>  bool GraphicsContext3DInternal::texImage2D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dint border, GC3Denum format, GC3Denum type, const void* pixels)
>  {
> +    if (width > m_maxTextureSize || height > m_maxTextureSize) {
> +      synthesizeGLError(GraphicsContext3D::INVALID_VALUE);
> +      return false;
> +    }

It seems weird to short-circuit the normal error handling, but only for this function and only for chromium.  What do you think, Ken?

This check is wrong if level != 0, I believe.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.