[Webkit-unassigned] [Bug 50661] Convert <meter> shadow DOM to a DOM-based shadow.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50661





--- Comment #7 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-04-04 11:39:35 PST ---
(From update of attachment 88082)
View in context: https://bugs.webkit.org/attachment.cgi?id=88082&action=review

Two concerns:

1) Do we really need filling element? Can't the meter itself act as the filling?
2) creating subtree on attach seems wrong. We'll be adding DOM elements at the time when we're supposed to be populating the render tree.

> LayoutTests/ChangeLog:9
> +        Also updated meter-styles.html pixel result because the render tree is now layouted

layouted -> laid out

> Source/WebCore/ChangeLog:15
> +          -webkit-appeearance is "none" and the platform supports <meter>.

-webkit-appearance

> Source/WebCore/ChangeLog:18
> +          indicators are painted using the platform theme engine as same
> +          old.

as before.

> Source/WebCore/css/CSSMutableStyleDeclaration.cpp:615
> +bool CSSMutableStyleDeclaration::setProperty(int propertyID, double value, CSSPrimitiveValue::UnitTypes unit, bool important, bool notifyChanged)
> +{
> +    CSSProperty property(propertyID, CSSPrimitiveValue::create(value, unit), important);
> +    setPropertyInternal(property);
> +    if (notifyChanged)
> +        setNeedsStyleRecalc();
> +    return true;
> +}

Do you need this change? Can you not just use

> Source/WebCore/html/shadow/MeterShadowElement.cpp:52
> +    getInlineStyleDecl()->setProperty(CSSPropertyWebkitBoxFlex, flex, CSSPrimitiveValue::CSS_NUMBER);

can be just style()->

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.