[Webkit-unassigned] [Bug 57328] Introspection: missing signal annotations

Mon Apr 4 10:37:59 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=57328

Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87305|                            |review-
               Flag|                            |

--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2011-04-04 10:37:59 PST ---
(From update of attachment 87305)
Thanks for the patch! To land the patch we need a ChangeLog entry you can generate with ./Tools/Scripts/prepare-ChangeLog (use --git-commit HEAD if you are using git and committed the changes). Also, you can keep your copyright, the WebKit project does not require copyright assignment, feel free to add your name to the header.

Now for comments on the content: the addition of documentation for hovering-over-link is welcome. Do we really need to add documentation to set-scroll-adjustments, since it's actually being overriden from GtkWidget? As for the other signals, they are undocumented on purpose - their design is not finished, and they only exist for internal purposes at this point (for the test runner). These signals may change, so perhaps we would need to annotate them to be ignored. Marking r- for these reasons and for lack of ChangeLog, thanks for working on this!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.