[Webkit-unassigned] [Bug 56586] Media Stream API: add the getUserMedia method and the Javascript bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56586





--- Comment #33 from Steve Block <steveblock at google.com>  2011-04-04 07:24:33 PST ---
(From update of attachment 87905)
View in context: https://bugs.webkit.org/attachment.cgi?id=87905&action=review

> LayoutTests/fast/dom/MediaStream/script-tests/argument-types.js:35
> +// 1 Argument

Maybe add a comment that the reason all these throw is not due to the type conversion, but simply because the API requires 2 arguments. Test with emptyFunction too for completeness.

> LayoutTests/fast/dom/MediaStream/script-tests/argument-types.js:40
> +test('navigator.webkitGetUserMedia("video")', true);

Could use "video" for the other arguments below, too.

> LayoutTests/fast/dom/MediaStream/script-tests/argument-types.js:52
> +test('navigator.webkitGetUserMedia(objectThrowingException, emptyFunction)', false);

Shouldn't this one throw 'valueOf threw exception'? Or does toString() not use valueOf()? Maybe try an object with a custom toString() that throws?

>> LayoutTests/fast/dom/MediaStream/script-tests/argument-types.js:76
>> +test('navigator.webkitGetUserMedia("video", emptyFunction, -Infinity)', true);
> 
> I don't think that any of these should throw, other than the one using objectThrowingException. I think the argument should just get converted to a string using the normal JS conversions.

Sorry, just realised that this comment is wrong - ignore it. I was getting confused with the Geolocation API.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.