[Webkit-unassigned] [Bug 57749] Web Inspector: Highlighted search tokens would not be shown on long lines in the text viewer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 4 05:17:44 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57749


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88048|review?                     |review+
               Flag|                            |




--- Comment #2 from Yury Semikhatsky <yurys at chromium.org>  2011-04-04 05:17:44 PST ---
(From update of attachment 88048)
View in context: https://bugs.webkit.org/attachment.cgi?id=88048&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:1029
> +            if (this._rangeToMark && this._rangeToMark.startLine === lineNumber)

Consider refactoring this method and extracting syntax highlight and search result highlight into separate methods.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list