[Webkit-unassigned] [Bug 56904] [EFL] Update signals description

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56904





--- Comment #13 from Grzegorz <g.czajkowski at samsung.com>  2011-04-04 00:21:49 PST ---
(In reply to comment #10)
> (From update of attachment 87672 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87672&action=review
> 
> It looks fine, but might need an extra interaction. If ProFusion guys want to validate, it would be know.
> 
> > Source/WebKit/efl/ewk/ewk_contextmenu.h:29
> > + *  - "contextmenu,free", Ewk_Context_Menu *: a context menu is freed.
> 
> freed. Would hidden be better?

This signal is emitted when context menu is destroyed (free method is called on:
 - all items of the context menu
 - the context menu

so, in my opinion we should leave "free" in signal discription


> 
> > Source/WebKit/efl/ewk/ewk_view.h:77
> > + *  - "link,hover,in", const char *link[2]: reports mouse is over a link
> > + *    it gives the url in link[0] and link's title in link[1] as an argument.
> 
> I think there could be a period between these two lines.

fixed, description was splitted up into two sentences.

> 
> > Source/WebKit/efl/ewk/ewk_view.h:91
> > + *  - "tooltip,text,set", const char*: sets tooltip text and display if it is currently hidden.
> 
> displays*

fixed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.