[Webkit-unassigned] [Bug 56942] EventSource should only accept UTF-8 charset

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56942


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88028|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #15 from Alexey Proskuryakov <ap at webkit.org>  2011-04-03 21:02:38 PST ---
(From update of attachment 88028)
View in context: https://bugs.webkit.org/attachment.cgi?id=88028&action=review

> LayoutTests/ChangeLog:21
> +        in the URL. Also added a work-around a bug in PHP.

I don't think that it's a bug. A quick web search suggested that it's a configuration option, and we should do something like:

if (get_magic_quotes_gpc()){
    $value = stripslashes($value);
}

See also: <http://php.net/manual/en/function.stripslashes.php>, <http://php.net/manual/en/function.get-magic-quotes-gpc.php>.

Please use the proposed pattern, and fix the ChangeLog accordingly.

> LayoutTests/http/tests/eventsource/eventsource-content-type-charset.html:35
> +                     'text/event-stream; charset=windows-1152',

Did you mean to use a non-existent charset here? If so, 1152 is an overly subtle way to express that.

I think that we should test windows-1251 or us-ascii.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.