[Webkit-unassigned] [Bug 54230] [GTK] Implement WebPage class for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54230


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86969|review?                     |review+
               Flag|                            |




--- Comment #22 from Martin Robinson <mrobinson at webkit.org>  2011-04-01 15:40:11 PST ---
(From update of attachment 86969)
View in context: https://bugs.webkit.org/attachment.cgi?id=86969&action=review

Looks good. Please ensure that you have all the necessary WebPage stubs before landing.

> Source/WebKit2/ChangeLog:1
> +2011-03-25  Amruth Raj  <amruthraj at motorola.com> and Ravi Phaneendra Kasibhatla  <ravi.kasibhatla at motorola.com> and Alejandro G. Castro  <alex at igalia.com>

Probably best to use First, Second, and here.

> Source/WebKit2/UIProcess/WebPageProxy.h:-586
> -    

I would restore this newline.

> Source/WebKit2/UIProcess/gtk/WebView.h:68
> +    // Keyboard events handling.

You can omit this coment.

> Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:42
> +                                                m_page->pageID(), CoreIPC::Connection::NoTimeout);

Does it make sense to require a timeout for this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.