[Webkit-unassigned] [Bug 14845] Frame's noResize attribute can not be set by JavaScript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=14845





--- Comment #20 from Daniel Bates <dbates at webkit.org>  2011-04-01 11:34:53 PST ---
(In reply to comment #19)
> (From update of attachment 87056 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87056&action=review
> [...]
> I suggest we make the noResize() function non-inline and change it to call hasAttribute. This eliminates the need for an m_noResize data member.

Will remove instance variable m_noResize and make noResize() a non-inline  function.

> 
> I don’t understand the syntax "when frame.noResize := false" so I don’t know what your comment is saying.

The comment was trying to explain that the expression "!attr->isNull()" handles both the HTML attribute logic (when the HTML attribute is added and removed) as well as the JavaScript noResize property logic because the JavaScript-binding/DOM logic translates the noResize property setter to DOM attribute addition and removal (depending on the value being set).

> 
> > Source/WebCore/html/HTMLFrameElement.cpp:95
> > +        if (HTMLFrameSetElement* frameSetElement = containingFrameSetElement(this)) {
> > +            RenderObject* frameSetRenderer = frameSetElement->renderer();
> > +            if (frameSetRenderer && frameSetRenderer->isFrameSet())
> > +                toRenderFrameSet(frameSetRenderer)->computeEdgeInfo();
> > +        }
> [...]
> I think that here in HTMLFrameElement we should be calling updateFromRenderer on RenderFrame and RenderFrame in turn should be turning around and calling the RenderFrameSet to say that its edge info changed and then the RenderFrameSet, based on the fact that a frame called to say its edge info changed, will decide to recompute the edge info.

I like this approach. Will change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.