[Webkit-unassigned] [Bug 57618] [GTK] Main loop sources are leaked in RunLoopGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57618


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87847|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-04-01 10:01:30 PST ---
(From update of attachment 87847)
View in context: https://bugs.webkit.org/attachment.cgi?id=87847&action=review

Great work. Please consider the method name changes below before landing.

> Source/WebKit2/Platform/gtk/RunLoopGtk.cpp:95
> +void RunLoop::TimerBase::reset()

I think the name clearTimerSource better describes what this one does.

> Source/WebKit2/Platform/gtk/RunLoopGtk.cpp:100
> +void RunLoop::TimerBase::resetTimerSource(RunLoop::TimerBase* timer)

Please call this one destroyNotifyCallback to make it clear that this is just used as a callback.

> Source/WebKit2/Platform/gtk/RunLoopGtk.cpp:105
> +gboolean RunLoop::TimerBase::timerFired(RunLoop::TimerBase* timer)

Please call this one timerFiredCallback.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.