[Webkit-unassigned] [Bug 57584] [Chromium] Text anti-aliasing fails when rendering text with shadow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57584


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87864|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #4 from Kenneth Russell <kbr at google.com>  2011-04-01 09:45:45 PST ---
(From update of attachment 87864)
View in context: https://bugs.webkit.org/attachment.cgi?id=87864&action=review

The logic changes and test expectations updates look good. One minor style issue, just FYI, not necessary to fix. cq+'ing as is.

> Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:389
> +    if (!alpha && graphicsContext->platformContext()->getStrokeStyle() == NoStroke
> +        && !graphicsContext->hasShadow()) {

WebKit style doesn't have a line length, so this would be easier to read if it were all one line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.