[Webkit-unassigned] [Bug 57463] [GTK] ARIA tables not exposing cells as HTML tables do

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57463


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87839|review?                     |review-
               Flag|                            |




--- Comment #3 from chris fleizach <cfleizach at apple.com>  2011-04-01 09:21:05 PST ---
(From update of attachment 87839)
View in context: https://bugs.webkit.org/attachment.cgi?id=87839&action=review

> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:113
> +

!child check is not needed

> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:115
> +            if (appendedRows.contains(row))

this check could be in the previous check. there's no need to cast to a AccessibilityTableRow at this point

> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:119
> +            unsigned rowCellCount = row->children().size();

Store instead of "store"

> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:123
> +            row->setRowIndex((int)columnCount);

static_cast
also i don't think the rowIndex is the same as the columnCount. The row index should be m_rows.size()

> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:125
> +            m_children.append(row->children());

why is all this logic duplicated from addChild. Is there any difference with what you added?

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:450
> +    case GridRole:

i believe you removed this in another patch

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.