[Webkit-unassigned] [Bug 56752] [QT] The minimum size of the select menu list is incorrect for qtwebkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56752





--- Comment #14 from Benjamin Poulain <benjamin at webkit.org>  2011-04-01 08:50:52 PST ---
(From update of attachment 87862)
> Ben, The attached patch does not contain any additional code changes after your review but i rebaselined the failing testcases of select-list with reference to this change on VM. I make sure my change is not causing any other test case failures.

What value does the test add over existing tests? For me, it looks like the case where it adds coverage over the other tests is 
<select id="list3">
  <option></option>
</select> 

So I would put that one first to make thing clear. I would also add a <p>paragraph</p> at the top of the test to explain what it tests. Finally, it should probably be commited in the common tests and not as a Qt specific one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.