[Webkit-unassigned] [Bug 55960] [GTK] [WebKit2] WebView::windowToScreen needs an implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55960





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-04-01 07:59:32 PST ---
(From update of attachment 85222)
View in context: https://bugs.webkit.org/attachment.cgi?id=85222&action=review

> Source/WebKit2/UIProcess/gtk/WebView.cpp:243
> +    GtkWidget* toplevel = gtk_widget_get_toplevel(m_viewWidget);
> +    if (!toplevel || !gtk_widget_is_toplevel(toplevel) || !GTK_IS_WINDOW(toplevel))
> +        return rect;
> +
> +    int xInWindow, yInWindow;
> +    gtk_widget_translate_coordinates(m_viewWidget, toplevel, rect.x(), rect.y(), &xInWindow, &yInWindow);
> +    int windowOriginX, windowOriginY;
> +    gdk_window_get_origin(gtk_widget_get_window(toplevel), &windowOriginX, &windowOriginY);
> +
> +    IntRect rectInScreenCoordinates(rect);
> +    rectInScreenCoordinates.move(windowOriginX + xInWindow, windowOriginY + yInWindow);
> +    return rectInScreenCoordinates;

hmm, isn't all this the same than simply calling gdk_window_get_origin(gtk_widget_get_window(m_viewWidget), &x, &y); ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.