[Webkit-unassigned] [Bug 57548] Web Inspector: Separate sendMessageToFrontend function from InspectorClient to individual interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57548


Sergey Vorobyev <sergeyvorobyev at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87846|1                           |0
        is obsolete|                            |




--- Comment #4 from Sergey Vorobyev <sergeyvorobyev at google.com>  2011-04-01 07:51:20 PST ---
(From update of attachment 87846)
View in context: https://bugs.webkit.org/attachment.cgi?id=87846&action=review

>> Source/WebCore/WebCore.gypi:3224
>> +            'inspector/InspectorFrontendChannel.h',
> 
> Mind alphabetic order.

Done.

>> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22772
>> +				227777601345DEA9008EA455 /* InspectorFrontendChannel.h in Headers */,
> 
> Other headers in this section seem to be sorted, please keep the order.

This is auto-generated change, I just added file to the project in xcode

>> Source/WebCore/inspector/CodeGeneratorInspector.pm:100
>> +$typeTransform{"InspectorFrontendChannel"} = {
> 
> I think may not need "InspectorClient" forward declaration and header import anymore, please check and remove corresponding code from the generator if it is so.

Done.

>> Source/WebCore/inspector/InspectorClient.h:29
>> +#include "InspectorFrontendChannel.h"
> 
> Please add  Copyright (C) 2011 Google Inc.... header to the license above since you're modifying this file.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.