[Webkit-unassigned] [Bug 46953] Add simple API tester for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46953


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-09-30 19:16:47 PST ---
Attachment 69411 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/TestWebKitAPI/TestWebKitAPIPrefix.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/TestsController.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/Test.h:80:  TEST_CLASS_NAME is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WTF/Vector1.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WTF/Vector1.cpp:36:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/TestWebKitAPI/Tests/WTF/Vector1.cpp:37:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 8 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.